[Swig-devel] [MATLAB] Finishing the module, code review?

[Joel Andersson]

Hi all,

From what I can tell, all major features are now in place for the MATLAB

module (including support for multiple modules, directors). Great work
everyone!

There is still plenty of work resolving unit test failures (about 80 tests
pass at the moment, about 50 fail and a lot of tests are not tested at
all). We also need to write a chapter in the user guide.

Anyway, maybe now would be a good time for a code review? William?

Joel

[William S Fulton]

Sounds like good progress. I don't have much time, so I'd rather review the
code when it is ready for merging to master. That'll be when it is
completely finished and you have all the tests working. Otherwise the whole
review for merging to master takes so long and I'll end up having to redo
the review a few times. That's what has happened in the past and I just
don't have the time for that.

What's the plan for running ongoing CI tests? Successful CI testing with
preferably Travis or Appveyor is one criteria I have for accepting code
changes on master as without it, maintaining an ever expanding code base
with complex dependencies gets really hard and the target language will bit
rot (like the ones that don't get tested atm).

William

Post by Joel Andersson
Hi all,
From what I can tell, all major features are now in place for the MATLAB
module (including support for multiple modules, directors). Great work
everyone!
There is still plenty of work resolving unit test failures (about 80 tests
pass at the moment, about 50 fail and a lot of tests are not tested at
all). We also need to write a chapter in the user guide.
Anyway, maybe now would be a good time for a code review? William?
Joel
--
--
Joel Andersson, PhD
Ptge. Busquets 11-13, atico 3
E-08940 Cornella de Llobregat (Barcelona), Spain
Home: [phone]
Mobile: [phone] (in Sweden also [phone])
------------------------------------------------------------------------------
_______________________________________________
Swig-devel mailing list
https://lists.sourceforge.net/lists/listinfo/swig-devel

[Joel Andersson]

Hi,

OK, we'll keep working on the unit tests then.

For CasADi, Joris Gillis has successfully set up CI using both Appveyor
(Windows builds) and Travis (Linux, soon OSX). This includes the SWIG
generated MATLAB interface. I see no reason why the same wouldn't work for
SWIG from a technical point of view. What we need to work out however is
the license issue. I'll make another attempt to get Mathworks to grant us a
license for this and if it doesn't work out, figure out how much it would
cost to buy one. If someone already has made some progress here, let me
know.

Joel

Post by William S Fulton
Sounds like good progress. I don't have much time, so I'd rather review
the code when it is ready for merging to master. That'll be when it is
completely finished and you have all the tests working. Otherwise the whole
review for merging to master takes so long and I'll end up having to redo
the review a few times. That's what has happened in the past and I just
don't have the time for that.
What's the plan for running ongoing CI tests? Successful CI testing with
preferably Travis or Appveyor is one criteria I have for accepting code
changes on master as without it, maintaining an ever expanding code base
with complex dependencies gets really hard and the target language will bit
rot (like the ones that don't get tested atm).
William

Post by Joel Andersson
Hi all,
From what I can tell, all major features are now in place for the MATLAB
module (including support for multiple modules, directors). Great work
everyone!
There is still plenty of work resolving unit test failures (about 80
tests pass at the moment, about 50 fail and a lot of tests are not tested
at all). We also need to write a chapter in the user guide.
Anyway, maybe now would be a good time for a code review? William?
Joel
--
--
Joel Andersson, PhD
Ptge. Busquets 11-13, atico 3
E-08940 Cornella de Llobregat (Barcelona), Spain
Home: [phone]
Mobile: [phone] (in Sweden also [phone])
------------------------------------------------------------------------------
_______________________________________________
Swig-devel mailing list
https://lists.sourceforge.net/lists/listinfo/swig-devel